fix: replace deprecated pkg_resources with pathlib in benchmark test#485
Merged
thpierce merged 1 commit intoaws:masterfrom Mar 20, 2026
Merged
fix: replace deprecated pkg_resources with pathlib in benchmark test#485thpierce merged 1 commit intoaws:masterfrom
thpierce merged 1 commit intoaws:masterfrom
Conversation
pkg_resources is no longer bundled by default in Python 3.12+, causing ModuleNotFoundError that blocks all test collection. Replace with pathlib which is stdlib and works on all supported versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR checks have been failing across Python 3.9-3.12 due to
ModuleNotFoundError: No module named 'pkg_resources'intests/test_local_sampling_benchmark.py.pkg_resources(from setuptools) is deprecated and no longer bundled by default in newer Python versions. This causes test collection to fail entirely, blocking all core and ext tests.Fix
Replace
pkg_resources.resource_filenamewithpathlib.Path, which is stdlib and works on all supported Python versions.Relates to failing checks on PRs like #469, #480.